-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File deduplication #6332
Merged
Merged
File deduplication #6332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
December 12, 2024 21:57
abbaa2e
to
3cb9a66
Compare
6 tasks
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
January 6, 2025 18:18
0469519
to
aa9dc2b
Compare
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
January 15, 2025 13:52
f492186
to
ab4a882
Compare
This was referenced Jan 16, 2025
Hocuri
commented
Jan 18, 2025
link2xt
reviewed
Jan 18, 2025
link2xt
reviewed
Jan 18, 2025
Septias
reviewed
Jan 19, 2025
Septias
reviewed
Jan 19, 2025
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
January 19, 2025 19:55
20319b4
to
1fecd17
Compare
Septias
approved these changes
Jan 20, 2025
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
January 20, 2025 17:44
67e8651
to
abeb3d7
Compare
… correct when deduplicating
Co-authored-by: l <link2xt@testrun.org>
Co-authored-by: l <link2xt@testrun.org>
Co-authored-by: l <link2xt@testrun.org>
…_and_deduplicate()
Otherwise, Rust CI fails on windows
… file world-writeable This setting files to readonly keeps making problems, if there are more I'll just get rid of it
Hocuri
force-pushed
the
hoc/file-deduplication
branch
from
January 20, 2025 19:58
abeb3d7
to
1761804
Compare
link2xt
reviewed
Jan 21, 2025
1. We wouldn't be able to easily revert it since we would have some read-only, some writeable files in the blobdir 2. It proved more complex than thought, with Windows having different behavior than others 3. It didn't buy us anything really, because Desktop will anyway have to copy the file to a temporary one in order to show it, and on other platforms the user can't edit the blob files, anyway
Co-authored-by: l <link2xt@testrun.org>
link2xt
approved these changes
Jan 21, 2025
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving messages, blobs will be deduplicated with the new function
create_and_deduplicate_from_bytes()
. For sending files, this adds a new functionset_file_and_deduplicate()
instead of deduplicating by default.This is for #6265; read the issue description there for more details.
TODO:
accounts/2ff9fc096d2f46b6832b24a1ed99c0d6/dc.db-blobs
(53 chars), plus 64 chars for the filename would be 117).For later PRs:
BlobObject::create(…)
withBlobObject::create_and_deduplicate(…)
in order to deduplicate everytime core creates a filename
usually means "user-visible-name", not "name of the file on disk").Footnotes
Calculated with both https://printfn.github.io/fend/ and https://www.geogebra.org/calculator, both of which came to the same result (1,
2) ↩